Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: LayoutTests/media/track/track-webvtt-tc003-newlines.html

Issue 65493006: Remove a WebVTT newlines test that doesn't do what it says (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/media/track/track-webvtt-tc003-newlines.html
diff --git a/LayoutTests/media/track/track-webvtt-tc003-newlines.html b/LayoutTests/media/track/track-webvtt-tc003-newlines.html
index dfce10ac0564740923d57200eca0d7147f40711c..1bdf8316fa6b06beb59ccb342d308ed9f76dd618 100644
--- a/LayoutTests/media/track/track-webvtt-tc003-newlines.html
+++ b/LayoutTests/media/track/track-webvtt-tc003-newlines.html
@@ -6,22 +6,11 @@
<script src=../media-file.js></script>
<script src=../video-test.js></script>
<script>
-
- numberOfTrackTests = 2;
function trackLoaded()
{
- numberOfTracksLoaded++;
- if (numberOfTracksLoaded == numberOfTrackTests) {
- testTrack(0);
- testTrack(1);
- }
- }
-
- function testTrack(i)
- {
findMediaElement();
- var expected =
+ var expected =
{
length : 1,
tests:
@@ -44,17 +33,16 @@
},
],
};
- testCues(i, expected);
+ testCues(0, expected);
- allTestsEnded();
+ endTest();
}
</script>
</head>
- <body onload="enableAllTextTracks()">
- <p>Tests that line terminators \r, \n, or \r\n are properly parsed, even when there is no newline at eof.</p>
+ <body>
+ <p>Tests that a cue with no newline at eof is properly parsed.</p>
<video>
- <track src="captions-webvtt/tc003-newlines.vtt" onload="trackLoaded()">
- <track src="captions-webvtt/tc003-no-newline-at-eof.vtt" onload="trackLoaded()">
+ <track src="captions-webvtt/tc003-no-newline-at-eof.vtt" onload="trackLoaded()" default>
</video>
</body>
-</html>
+</html>

Powered by Google App Engine
This is Rietveld 408576698