increase coverage of SkPath.cpp, remove unused code

include/core/SkPath.h

Index: include/core/SkPath.h
diff --git a/include/core/SkPath.h b/include/core/SkPath.h
index 2b111fe505915fa0fb8025625f64950444f9b161..04cbcfd4524d561576490d88f03ee198843c51ec 100644
--- a/include/core/SkPath.h
+++ b/include/core/SkPath.h
@@ -889,12 +889,6 @@ public:
         SkPoint         fLastPt;
     };
 
-    /**
-     *  Returns true if the point { x, y } is contained by the path, taking into
-     *  account the FillType.
-     */
-    bool contains(SkScalar x, SkScalar y) const;

[reed1, 2013/11/13 18:37:52]

This guy was written partly to optimize the code in webkit's SkiaUtils.cpp
SkPathContainsPoint. Obviously we haven't make that connection yet, but I think
we should.

[caryclark, 2013/11/13 18:52:37]

I can put it back. It isn't called today within Skia or Chrome; there are no
tests, and when I wrote a test, I discovered the code didn't work.

On the other hand, it could either be in, but commented out, or be retrieved in
the future from the repository if the current code is a good starting point.
Just let me know what you'd prefer.

[reed1, 2013/11/13 18:58:58]

Well, it was called, until you removed the GM that called it.

If you have a test that fails, lets add that to a bug, and I'll try to fix it.

-
     void dump(bool forceClose, const char title[] = NULL) const;
     void dump() const;
 
@@ -972,11 +966,6 @@ private:
     friend class Iter;
 
     friend class SkPathStroker;
-    /*  Append the first contour of path, ignoring path's initial point. If no
-        moveTo() call has been made for this contour, the first point is
-        automatically set to (0,0).
-    */
-    void pathTo(const SkPath& path);
 
     /*  Append, in reverse order, the first contour of path, ignoring path's
         last point. If no moveTo() call has been made for this contour, the
@@ -1019,7 +1008,8 @@ private:
     friend class SkAutoPathBoundsUpdate;
     friend class SkAutoDisableOvalCheck;
     friend class SkAutoDisableDirectionCheck;
-    friend class SkBench_AddPathTest; // perf test pathTo/reversePathTo
+    friend class SkBench_AddPathTest; // perf test reversePathTo
+    friend class PathTest_Private; // unit test reversePathTo
 };
 
 #endif