src/core/SkRecordDraw.cpp - Issue 654873003: Implicit SkTextBlob bounds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkRecordDraw.cpp

Issue 654873003: Implicit SkTextBlob bounds (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: we don't need glyph widths Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkRecordDraw.cpp

diff --git a/src/core/SkRecordDraw.cpp b/src/core/SkRecordDraw.cpp

index 45324b8cecba03a10346a0abab4a2a192f5becde..577ffa125e1b9862228501495c3a3a1ba45014b3 100644

--- a/src/core/SkRecordDraw.cpp

+++ b/src/core/SkRecordDraw.cpp

@@ -456,10 +456,6 @@ private:

Bounds bounds(const DrawTextBlob& op) const {

SkRect dst = op.blob->bounds();

dst.offset(op.x, op.y);

- // TODO: remove when implicit bounds are plumbed through

- if (dst.isEmpty()) {

- return fCurrentClipBounds;

- }

return this->adjustAndMap(dst, &op.paint);

}

« no previous file with comments | « src/core/SkCanvas.cpp ('k') | src/core/SkTextBlob.cpp » ('j') | no next file with comments »