src/core/SkCanvas.cpp - Issue 654873003: Implicit SkTextBlob bounds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkCanvas.cpp

Issue 654873003: Implicit SkTextBlob bounds (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: we don't need glyph widths Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkCanvas.cpp

diff --git a/src/core/SkCanvas.cpp b/src/core/SkCanvas.cpp

index c57add408fc881972caabf7b94271203ab1fa8f8..709cb4c0be3ece59c86a5873c28d12b8c1f12a37 100644

--- a/src/core/SkCanvas.cpp

+++ b/src/core/SkCanvas.cpp

@@ -2195,9 +2195,7 @@ void SkCanvas::onDrawTextOnPath(const void* text, size_t byteLength, const SkPat

void SkCanvas::onDrawTextBlob(const SkTextBlob* blob, SkScalar x, SkScalar y,

const SkPaint& paint) {

- // FIXME: temporarily disable quickreject for empty bounds,

- // pending implicit blob bounds implementation.

- if (!blob->bounds().isEmpty() && paint.canComputeFastBounds()) {

+ if (paint.canComputeFastBounds()) {

SkRect storage;

if (this->quickReject(paint.computeFastBounds(blob->bounds().makeOffset(x, y), &storage))) {

« no previous file with comments | « expectations/gm/ignored-tests.txt ('k') | src/core/SkRecordDraw.cpp » ('j') | no next file with comments »