Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 654833002: [turbofan] Optimize division/modulus by constant. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
Sven Panne, dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize division/modulus by constant. TEST=cctest,mjsunit,unittests R=dcarney@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24595

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+770 lines, -217 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 3 chunks +23 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-codes-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 5 chunks +124 lines, -43 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 3 chunks +42 lines, -28 lines 0 comments Download
A test/mjsunit/asm/int32div.js View 1 chunk +33 lines, -0 lines 0 comments Download
A test/mjsunit/asm/int32mod.js View 1 chunk +33 lines, -0 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 2 chunks +98 lines, -29 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M test/unittests/compiler/graph-unittest.h View 2 chunks +6 lines, -0 lines 0 comments Download
M test/unittests/compiler/graph-unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc View 6 chunks +22 lines, -0 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 7 chunks +247 lines, -88 lines 0 comments Download
M test/unittests/compiler/machine-operator-unittest.cc View 1 chunk +30 lines, -29 lines 0 comments Download
M test/unittests/compiler/x64/instruction-selector-x64-unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
6 years, 2 months ago (2014-10-14 11:35:19 UTC) #1
dcarney
lgtm
6 years, 2 months ago (2014-10-14 11:52:55 UTC) #3
Benedikt Meurer
6 years, 2 months ago (2014-10-14 11:57:33 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 24595 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698