[turbofan] Optimize division/modulus by constant.

test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "test/unittests/compiler/instruction-selector-unittest.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
@@ skipping 85 matching lines @@
   ASSERT_EQ(1U, s.size());
   EXPECT_EQ(kSSECvtsd2ss, s[0]->arch_opcode());
   EXPECT_EQ(1U, s[0]->InputCount());
   EXPECT_EQ(1U, s[0]->OutputCount());
 }
 
 
 // -----------------------------------------------------------------------------
 // Better left operand for commutative binops
 
+
 TEST_F(InstructionSelectorTest, BetterLeftOperandTestAddBinop) {
   StreamBuilder m(this, kMachInt32, kMachInt32, kMachInt32);
   Node* param1 = m.Parameter(0);
   Node* param2 = m.Parameter(1);
   Node* add = m.Int32Add(param1, param2);
   m.Return(m.Int32Add(add, param1));
   Stream s = m.Build();
   ASSERT_EQ(2U, s.size());
   EXPECT_EQ(kIA32Add, s[0]->arch_opcode());
   ASSERT_EQ(2U, s[0]->InputCount());
@@ skipping 13 matching lines @@
   EXPECT_EQ(kIA32Imul, s[0]->arch_opcode());
   ASSERT_EQ(2U, s[0]->InputCount());
   ASSERT_TRUE(s[0]->InputAt(0)->IsUnallocated());
   EXPECT_EQ(s.ToVreg(param2), s.ToVreg(s[0]->InputAt(0)));
 }
 
 
 // -----------------------------------------------------------------------------
 // Conversions.
 
+
 TEST_F(InstructionSelectorTest, ChangeUint32ToFloat64WithParameter) {
   StreamBuilder m(this, kMachFloat64, kMachUint32);
   m.Return(m.ChangeUint32ToFloat64(m.Parameter(0)));
   Stream s = m.Build();
   ASSERT_EQ(1U, s.size());
   EXPECT_EQ(kSSEUint32ToFloat64, s[0]->arch_opcode());
 }
 
 
 // -----------------------------------------------------------------------------
 // Loads and stores
 
+
 namespace {
 
 struct MemoryAccess {
   MachineType type;
   ArchOpcode load_opcode;
   ArchOpcode store_opcode;
 };
 
 
 std::ostream& operator<<(std::ostream& os, const MemoryAccess& memacc) {
@@ skipping 127 matching lines @@
 
 
 INSTANTIATE_TEST_CASE_P(InstructionSelectorTest,
                         InstructionSelectorMemoryAccessTest,
                         ::testing::ValuesIn(kMemoryAccesses));
 
 
 // -----------------------------------------------------------------------------
 // AddressingMode for loads and stores.
 
+
 class AddressingModeUnitTest : public InstructionSelectorTest {
  public:
   AddressingModeUnitTest() : m(NULL) { Reset(); }
   ~AddressingModeUnitTest() { delete m; }
 
   void Run(Node* base, Node* index, AddressingMode mode) {
     Node* load = m->Load(kMachInt32, base, index);
     m->Store(kMachInt32, base, index, load);
     m->Return(m->Int32Constant(0));
     Stream s = m->Build();
@@ skipping 123 matching lines @@
       Node* index = indices[j];
       Run(base, index, kMode_MI);
     }
   }
 }
 
 
 // -----------------------------------------------------------------------------
 // Multiplication.
 
+
 namespace {
 
 struct MultParam {
   int value;
   bool lea_expected;
   AddressingMode addressing_mode;
 };
 
 
 std::ostream& operator<<(std::ostream& os, const MultParam& m) {
@@ skipping 118 matching lines @@
       EXPECT_EQ(kIA32Imul, s[0]->arch_opcode());
       EXPECT_EQ(kIA32Add, s[1]->arch_opcode());
     }
   }
 }
 
 
 INSTANTIATE_TEST_CASE_P(InstructionSelectorTest, InstructionSelectorMultTest,
                         ::testing::ValuesIn(kMultParams));
 
+
+TEST_F(InstructionSelectorTest, Int32MulHigh) {
+  StreamBuilder m(this, kMachInt32, kMachInt32, kMachInt32);
+  Node* const p0 = m.Parameter(0);
+  Node* const p1 = m.Parameter(1);
+  Node* const n = m.Int32MulHigh(p0, p1);
+  m.Return(n);
+  Stream s = m.Build();
+  ASSERT_EQ(1U, s.size());
+  EXPECT_EQ(kIA32ImulHigh, s[0]->arch_opcode());
+  ASSERT_EQ(2U, s[0]->InputCount());
+  EXPECT_EQ(s.ToVreg(p0), s.ToVreg(s[0]->InputAt(0)));
+  EXPECT_EQ(s.ToVreg(p1), s.ToVreg(s[0]->InputAt(1)));
+  ASSERT_EQ(1U, s[0]->OutputCount());
+  EXPECT_EQ(s.ToVreg(n), s.ToVreg(s[0]->Output()));
+}
+
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8