Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 654753003: DevTools: text node rendering in the console regressed when migrated to promises. (Closed)

Created:
6 years, 2 months ago by pfeldman
Modified:
6 years, 2 months ago
Reviewers:
kozyatinskiy1, vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: text node rendering in the console regressed when migrated to promises. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184203

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M LayoutTests/http/tests/inspector/console-test.js View 2 chunks +3 lines, -1 line 0 comments Download
M LayoutTests/inspector/console/console-format.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/console/console-format-expected.txt View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/devtools/front_end/console/ConsoleViewMessage.js View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
pfeldman
6 years, 2 months ago (2014-10-22 15:23:18 UTC) #2
kozyatinskiy1
lgtm
6 years, 2 months ago (2014-10-22 15:46:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654753003/1
6 years, 2 months ago (2014-10-22 15:48:18 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-22 15:48:21 UTC) #8
vsevik
lgtm
6 years, 2 months ago (2014-10-22 16:07:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654753003/1
6 years, 2 months ago (2014-10-22 16:11:22 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 18:01:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184203

Powered by Google App Engine
This is Rietveld 408576698