Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 654753003: DevTools: text node rendering in the console regressed when migrated to promises. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/inspector/console/console-format-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/Source/devtools/front_end/console/ConsoleViewMessage.js b/Source/devtools/front_end/console/ConsoleViewMessage.js
index bc3a72d12b0d7065fe7b8c8190a76e4ea757d672..2d88c73e68ef891d651f7e396b49ff3327815f3f 100644
--- a/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -598,7 +598,7 @@ WebInspector.ConsoleViewMessage.prototype = {
*/
_formatParameterAsNode: function(object, elem)
{
- WebInspector.Renderer.renderPromise(object).then(appendRenderer).done();
+ WebInspector.Renderer.renderPromise(object).then(appendRenderer, failedToRender.bind(this)).done();
/**
* @param {!Element} rendererElement
*/
@@ -606,6 +606,14 @@ WebInspector.ConsoleViewMessage.prototype = {
{
elem.appendChild(rendererElement);
}
+
+ /**
+ * @this {WebInspector.ConsoleViewMessage}
+ */
+ function failedToRender()
+ {
+ this._formatParameterAsObject(object, elem, false);
+ }
},
/**
« no previous file with comments | « LayoutTests/inspector/console/console-format-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698