Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 654713004: [chromedriver] Add support for all target types from DevToolsTargetImpl (Closed)

Created:
6 years, 2 months ago by samuong
Modified:
6 years, 2 months ago
Reviewers:
stgao
CC:
chromium-reviews, vsevik, samuong+watch_chromium.org, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, stgao, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Add support for all target types from DevToolsTargetImpl BUG=chromedriver:916 Committed: https://crrev.com/16150ec327fd49d13043c2ce580cecd3caebb0e7 Cr-Commit-Position: refs/heads/master@{#300522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -20 lines) Patch
M chrome/test/chromedriver/chrome/devtools_http_client.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/chrome/devtools_http_client.cc View 2 chunks +27 lines, -17 lines 0 comments Download
M chrome/test/chromedriver/chrome/devtools_http_client_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
samuong
Shuotao, I added support for webview the other day, but there are a few more ...
6 years, 2 months ago (2014-10-21 05:55:39 UTC) #2
stgao
Great, lgtm
6 years, 2 months ago (2014-10-21 17:11:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654713004/1
6 years, 2 months ago (2014-10-21 17:16:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 18:03:55 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 18:05:10 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/16150ec327fd49d13043c2ce580cecd3caebb0e7
Cr-Commit-Position: refs/heads/master@{#300522}

Powered by Google App Engine
This is Rietveld 408576698