chrome/test/chromedriver/chrome/devtools_http_client_unittest.cc - Issue 654713004: [chromedriver] Add support for all target types from DevToolsTargetImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/devtools_http_client_unittest.cc

Issue 654713004: [chromedriver] Add support for all target types from DevToolsTargetImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/chromedriver/chrome/devtools_http_client_unittest.cc

diff --git a/chrome/test/chromedriver/chrome/devtools_http_client_unittest.cc b/chrome/test/chromedriver/chrome/devtools_http_client_unittest.cc

index 1af04b784d2f78e35034d4d5075124870764be07..509df0914db4800e0673ec5fc4533f17d1dab6f1 100644

--- a/chrome/test/chromedriver/chrome/devtools_http_client_unittest.cc

+++ b/chrome/test/chromedriver/chrome/devtools_http_client_unittest.cc

@@ -95,7 +95,10 @@ TEST(ParseWebViewsInfo, Types) {

AssertTypeIsOk("background_page", WebViewInfo::kBackgroundPage);

AssertTypeIsOk("page", WebViewInfo::kPage);

AssertTypeIsOk("worker", WebViewInfo::kWorker);

+ AssertTypeIsOk("webview", WebViewInfo::kWebView);

+ AssertTypeIsOk("iframe", WebViewInfo::kIFrame);

AssertTypeIsOk("other", WebViewInfo::kOther);

+ AssertTypeIsOk("service_worker", WebViewInfo::kServiceWorker);

AssertFails("[{\"type\": \"\", \"id\": \"1\", \"url\": \"http://page1\"}]");

}

« no previous file with comments | « chrome/test/chromedriver/chrome/devtools_http_client.cc ('k') | no next file » | no next file with comments »