Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 654693004: Remove meta viewport and @viewport CSS rules. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove meta viewport and @viewport CSS rules. We won't need configurations like this since we don't have things like page zoom and a default width. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f6609ff110b273e2dccd9edfa851746e717bbd41

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1493 lines) Patch
M sky/engine/bindings/core/v8/custom/V8CSSRuleCustom.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/core.gni View 4 chunks +0 lines, -7 lines 0 comments Download
M sky/engine/core/css/CSSPropertySourceData.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSRule.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSRule.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSRule.idl View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/core/css/CSSViewportRule.h View 1 chunk +0 lines, -70 lines 0 comments Download
D sky/engine/core/css/CSSViewportRule.cpp View 1 chunk +0 lines, -93 lines 0 comments Download
D sky/engine/core/css/CSSViewportRule.idl View 1 chunk +0 lines, -32 lines 0 comments Download
M sky/engine/core/css/RuleSet.h View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/RuleSet.cpp View 4 chunks +0 lines, -10 lines 0 comments Download
M sky/engine/core/css/StyleRule.h View 4 chunks +0 lines, -25 lines 0 comments Download
M sky/engine/core/css/StyleRule.cpp View 7 chunks +0 lines, -48 lines 0 comments Download
M sky/engine/core/css/StyleSheetContents.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser.h View 1 chunk +0 lines, -29 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 3 chunks +2 lines, -27 lines 0 comments Download
M sky/engine/core/css/parser/CSSGrammar.y View 6 chunks +0 lines, -22 lines 0 comments Download
M sky/engine/core/css/parser/CSSTokenizer-in.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/resolver/ScopedStyleResolver.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/resolver/ScopedStyleResolver.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.h View 4 chunks +0 lines, -7 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 6 chunks +0 lines, -18 lines 0 comments Download
D sky/engine/core/css/resolver/ViewportStyleResolver.h View 1 chunk +0 lines, -76 lines 0 comments Download
D sky/engine/core/css/resolver/ViewportStyleResolver.cpp View 1 chunk +0 lines, -206 lines 0 comments Download
M sky/engine/core/dom/Document.h View 5 chunks +0 lines, -15 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 chunk +0 lines, -36 lines 0 comments Download
D sky/engine/core/dom/ViewportDescription.h View 1 chunk +0 lines, -135 lines 0 comments Download
D sky/engine/core/dom/ViewportDescription.cpp View 1 chunk +0 lines, -121 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/Settings.in View 3 chunks +3 lines, -9 lines 0 comments Download
M sky/engine/core/frame/SettingsDelegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLMetaElement.h View 2 chunks +0 lines, -23 lines 1 comment Download
M sky/engine/core/html/HTMLMetaElement-in.cpp View 3 chunks +2 lines, -383 lines 0 comments Download
M sky/engine/core/loader/FrameLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/page/Chrome.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/page/Chrome.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/page/ChromeClient.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/page/Page.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/page/Page.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M sky/engine/public/web/WebSettings.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/web/ChromeClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/web/WebSettingsImpl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/web/WebSettingsImpl.cpp View 2 chunks +0 lines, -15 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 2 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ojan
6 years, 1 month ago (2014-10-26 00:46:24 UTC) #2
abarth-chromium
LGTM https://codereview.chromium.org/654693004/diff/1/sky/engine/core/html/HTMLMetaElement.h File sky/engine/core/html/HTMLMetaElement.h (right): https://codereview.chromium.org/654693004/diff/1/sky/engine/core/html/HTMLMetaElement.h#newcode30 sky/engine/core/html/HTMLMetaElement.h:30: class HTMLMetaElement final : public HTMLElement { We ...
6 years, 1 month ago (2014-10-26 02:08:46 UTC) #3
ojan
On 2014/10/26 at 02:08:46, abarth wrote: > LGTM > > https://codereview.chromium.org/654693004/diff/1/sky/engine/core/html/HTMLMetaElement.h > File sky/engine/core/html/HTMLMetaElement.h (right): ...
6 years, 1 month ago (2014-10-26 05:46:56 UTC) #4
ojan
Committed patchset #1 (id:1) manually as f6609ff110b273e2dccd9edfa851746e717bbd41.
6 years, 1 month ago (2014-10-26 06:09:03 UTC) #5
eseidel
6 years, 1 month ago (2014-10-27 16:14:41 UTC) #6
Message was sent while issue was closed.
So without @viewport, how does one target differnet screen-sizes?  Separate CSS
files?

Powered by Google App Engine
This is Rietveld 408576698