Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: sky/engine/core/css/RuleSet.cpp

Issue 654693004: Remove meta viewport and @viewport CSS rules. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/css/RuleSet.cpp
diff --git a/sky/engine/core/css/RuleSet.cpp b/sky/engine/core/css/RuleSet.cpp
index 676b5cc861ce00f21266f0dd30a7d1a83cc49525..6227d1429ec439d7cc28752463c2e496316ea623 100644
--- a/sky/engine/core/css/RuleSet.cpp
+++ b/sky/engine/core/css/RuleSet.cpp
@@ -165,12 +165,6 @@ void RuleSet::addRule(StyleRule* rule, unsigned selectorIndex, AddRuleFlags addR
}
}
-void RuleSet::addViewportRule(StyleRuleViewport* rule)
-{
- ensurePendingRules(); // So that m_viewportRules.shrinkToFit() gets called.
- m_viewportRules.append(rule);
-}
-
void RuleSet::addFontFaceRule(StyleRuleFontFace* rule)
{
ensurePendingRules(); // So that m_fontFaceRules.shrinkToFit() gets called.
@@ -202,8 +196,6 @@ void RuleSet::addChildRules(const WillBeHeapVector<RefPtrWillBeMember<StyleRuleB
addFontFaceRule(toStyleRuleFontFace(rule));
} else if (rule->isKeyframesRule()) {
addKeyframesRule(toStyleRuleKeyframes(rule));
- } else if (rule->isViewportRule()) {
- addViewportRule(toStyleRuleViewport(rule));
} else if (rule->isSupportsRule() && toStyleRuleSupports(rule)->conditionIsSupported()) {
addChildRules(toStyleRuleSupports(rule)->childRules(), medium, addRuleFlags);
}
@@ -251,7 +243,6 @@ void RuleSet::compactRules()
compactPendingRules(pendingRules->tagRules, m_tagRules);
compactPendingRules(pendingRules->shadowPseudoElementRules, m_shadowPseudoElementRules);
m_universalRules.shrinkToFit();
- m_viewportRules.shrinkToFit();
m_fontFaceRules.shrinkToFit();
m_keyframesRules.shrinkToFit();
}
@@ -280,7 +271,6 @@ void RuleSet::trace(Visitor* visitor)
visitor->trace(m_shadowPseudoElementRules);
visitor->trace(m_universalRules);
visitor->trace(m_features);
- visitor->trace(m_viewportRules);
visitor->trace(m_fontFaceRules);
visitor->trace(m_keyframesRules);
visitor->trace(m_viewportDependentMediaQueryResults);

Powered by Google App Engine
This is Rietveld 408576698