Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 654653004: [arm] Drop SMMLS support. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[arm] Drop SMMLS support. Apparently SMMLS r, b, c, a computes r = ((a << 32) - b * c) >> 32 while the documentation is kinda misleading and states that it should compute r = a - ((b * c) >> 32) The actual behavior is kinda useless, so we drop the instruction again. TEST=cctest,unittests TBR=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24577

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -82 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/arm/disasm-arm.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/base/bits.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/base/bits.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/unittests/base/bits-unittest.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Benedikt Meurer
6 years, 2 months ago (2014-10-14 07:47:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24577 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698