Enables the user to select multiple languages for spellchecking (UI)

chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h

Index: chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h
diff --git a/chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h b/chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h
index bd0fa392f7c6ba4c1262dfa3eb2c2168de561116..00d0684d5520622ae87dba52e2f80f47cd78dd94 100644
--- a/chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h
+++ b/chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h
@@ -5,6 +5,7 @@
 #ifndef CHROME_BROWSER_RENDERER_CONTEXT_MENU_SPELLCHECKER_SUBMENU_OBSERVER_H_
 #define CHROME_BROWSER_RENDERER_CONTEXT_MENU_SPELLCHECKER_SUBMENU_OBSERVER_H_
 
+#include <set>
 #include <string>
 #include <vector>
 
@@ -13,6 +14,7 @@
 #include "components/renderer_context_menu/render_view_context_menu_observer.h"
 #include "ui/base/models/simple_menu_model.h"
 
+class PrefService;
 class RenderViewContextMenuProxy;
 
 // A class that implements the 'spell-checker options' submenu. This class
@@ -43,7 +45,7 @@ class SpellCheckerSubMenuObserver : public RenderViewContextMenuObserver {
   // Hunspell spelling submenu.
   // The radio items representing languages available for spellchecking.
   int language_group_;
-  int language_selected_;
+  std::set<int> languages_selected_;
   std::vector<std::string> languages_;

[please use gerrit instead, 2014/11/07 16:24:49]

Please add comments for all three variables and think about  better names for
"languages_selected_" and "languages_". Maybe "spellcheck_languages_" and
"accepted_languages_". I'm suggesting "accepted_languages_" because Chrome uses
the languages from chrome://settings/languages to let the webpage know which
languages the user can read and the browser can accept.

[Klemen Forstnerič, 2014/11/11 21:52:01]

Acknowledged.

 #endif  // !OS_MACOSX