Enables the user to select multiple languages for spellchecking (UI)

chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_RENDERER_CONTEXT_MENU_SPELLCHECKER_SUBMENU_OBSERVER_H_
 #define CHROME_BROWSER_RENDERER_CONTEXT_MENU_SPELLCHECKER_SUBMENU_OBSERVER_H_
 
+#include <set>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "components/renderer_context_menu/render_view_context_menu_observer.h"
 #include "ui/base/models/simple_menu_model.h"
 
+class PrefService;
 class RenderViewContextMenuProxy;
 
 // A class that implements the 'spell-checker options' submenu. This class
 // creates the submenu, add it to the parent menu, and handles events.
 class SpellCheckerSubMenuObserver : public RenderViewContextMenuObserver {
  public:
   SpellCheckerSubMenuObserver(RenderViewContextMenuProxy* proxy,
                               ui::SimpleMenuModel::Delegate* delegate,
                               int group);
   virtual ~SpellCheckerSubMenuObserver();
@@ skipping 10 matching lines @@
   RenderViewContextMenuProxy* proxy_;
 
   // The submenu of the 'spell-checker options'. This class adds items to this
   // submenu and add it to the parent menu.
   ui::SimpleMenuModel submenu_model_;
 
 #if !defined(OS_MACOSX)
   // Hunspell spelling submenu.
   // The radio items representing languages available for spellchecking.
   int language_group_;
-  int language_selected_;
+  std::set<int> languages_selected_;
   std::vector<std::string> languages_;

[please use gerrit instead, 2014/11/07 16:24:49]

Please add comments for all three variables and think about  better names for
"languages_selected_" and "languages_". Maybe "spellcheck_languages_" and
"accepted_languages_". I'm suggesting "accepted_languages_" because Chrome uses
the languages from chrome://settings/languages to let the webpage know which
languages the user can read and the browser can accept.

[Klemen Forstnerič, 2014/11/11 21:52:01]

Acknowledged.

 #endif  // !OS_MACOSX
 
   DISALLOW_COPY_AND_ASSIGN(SpellCheckerSubMenuObserver);
 };
 
 #endif  // CHROME_BROWSER_RENDERER_CONTEXT_MENU_SPELLCHECKER_SUBMENU_OBSERVER_H_