Source/bindings/tests/results/core/V8TestObject.cpp - Issue 654473002: JS binding: remove redundant type check in attr setter for TypeChecking interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestObject.cpp

Issue 654473002: JS binding: remove redundant type check in attr setter for TypeChecking interface (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: code rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterface.cpp ('k') | Source/bindings/tests/results/modules/V8TestInterface5.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestObject.cpp

diff --git a/Source/bindings/tests/results/core/V8TestObject.cpp b/Source/bindings/tests/results/core/V8TestObject.cpp

index c2ce1858fd9fd1968886a20136d6174ab85de177..f99687b83d6d3b759113e651653035ef1f507099 100644

--- a/Source/bindings/tests/results/core/V8TestObject.cpp

+++ b/Source/bindings/tests/results/core/V8TestObject.cpp

@@ -4461,7 +4461,7 @@ static void typeCheckingInterfaceTestInterfaceAttributeAttributeSetter(v8::Local

return;

}

TestObject* impl = V8TestObject::toImpl(holder);

- TestInterfaceImplementation* cppValue = V8TestInterface::toImplWithTypeCheck(info.GetIsolate(), v8Value);

+ TestInterfaceImplementation* cppValue = V8TestInterface::toImpl(v8::Handle<v8::Object>::Cast(v8Value));

impl->setTypeCheckingInterfaceTestInterfaceAttribute(WTF::getPtr(cppValue));

}