Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: Source/bindings/tests/results/core/V8TestInterface.cpp

Issue 654473002: JS binding: remove redundant type check in attr setter for TypeChecking interface (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: code rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/core/V8TestInterface.cpp
diff --git a/Source/bindings/tests/results/core/V8TestInterface.cpp b/Source/bindings/tests/results/core/V8TestInterface.cpp
index a8bd66384aa1b3437ff689dc3cc9a11055323886..56cf74bf30ca09935edacdf5703703c5d1e3d45d 100644
--- a/Source/bindings/tests/results/core/V8TestInterface.cpp
+++ b/Source/bindings/tests/results/core/V8TestInterface.cpp
@@ -70,7 +70,7 @@ static void testInterfaceAttributeAttributeSetter(v8::Local<v8::Value> v8Value,
return;
}
TestInterfaceImplementation* impl = V8TestInterface::toImpl(holder);
- TestInterfaceImplementation* cppValue = V8TestInterface::toImplWithTypeCheck(info.GetIsolate(), v8Value);
+ TestInterfaceImplementation* cppValue = V8TestInterface::toImpl(v8::Handle<v8::Object>::Cast(v8Value));
impl->setTestInterfaceAttribute(WTF::getPtr(cppValue));
}
@@ -430,7 +430,7 @@ static void implementsNodeAttributeAttributeSetter(v8::Local<v8::Value> v8Value,
return;
}
TestInterfaceImplementation* impl = V8TestInterface::toImpl(holder);
- Node* cppValue = V8Node::toImplWithTypeCheck(info.GetIsolate(), v8Value);
+ Node* cppValue = V8Node::toImpl(v8::Handle<v8::Object>::Cast(v8Value));
impl->setImplementsNodeAttribute(WTF::getPtr(cppValue));
}
@@ -495,7 +495,7 @@ static void implementsRuntimeEnabledNodeAttributeAttributeSetter(v8::Local<v8::V
return;
}
TestInterfaceImplementation* impl = V8TestInterface::toImpl(holder);
- Node* cppValue = V8Node::toImplWithTypeCheck(info.GetIsolate(), v8Value);
+ Node* cppValue = V8Node::toImpl(v8::Handle<v8::Object>::Cast(v8Value));
impl->setImplementsRuntimeEnabledNodeAttribute(WTF::getPtr(cppValue));
}
@@ -530,7 +530,7 @@ static void implementsPerContextEnabledNodeAttributeAttributeSetter(v8::Local<v8
return;
}
TestInterfaceImplementation* impl = V8TestInterface::toImpl(holder);
- Node* cppValue = V8Node::toImplWithTypeCheck(info.GetIsolate(), v8Value);
+ Node* cppValue = V8Node::toImpl(v8::Handle<v8::Object>::Cast(v8Value));
impl->setImplementsPerContextEnabledNodeAttribute(WTF::getPtr(cppValue));
}
« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698