Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 654253004: Update HTTP/2 DATA frame padding to 0x00. (Closed)

Created:
6 years, 2 months ago by Bence
Modified:
6 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Update HTTP/2 DATA frame padding to 0x00. Use 0x00 rather than 0x30 ('0') to pad the DATA frame to be comply with the HTTP/2 spec. This lands server change 77448497 by raullenchai. BUG=345769 Committed: https://crrev.com/8f97e51df97787225c1952e3d1bd094b01cae740 Cr-Commit-Position: refs/heads/master@{#300234}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -23 lines) Patch
M net/spdy/spdy_framer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_framer_test.cc View 2 chunks +24 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Bence
Ryan: PTAL. Thanks.
6 years, 2 months ago (2014-10-17 19:55:18 UTC) #2
Ryan Hamilton
lgtm https://codereview.chromium.org/654253004/diff/1/net/spdy/spdy_framer.cc File net/spdy/spdy_framer.cc (right): https://codereview.chromium.org/654253004/diff/1/net/spdy/spdy_framer.cc#newcode2318 net/spdy/spdy_framer.cc:2318: padding = string(data_ir.padding_payload_len(), 0); It seems like this ...
6 years, 2 months ago (2014-10-17 20:08:36 UTC) #3
Bence
Sorry, I overlooked that one. Thank you. https://codereview.chromium.org/654253004/diff/1/net/spdy/spdy_framer.cc File net/spdy/spdy_framer.cc (right): https://codereview.chromium.org/654253004/diff/1/net/spdy/spdy_framer.cc#newcode2318 net/spdy/spdy_framer.cc:2318: padding = ...
6 years, 2 months ago (2014-10-19 19:05:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654253004/20001
6 years, 2 months ago (2014-10-19 19:06:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-20 09:33:38 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 09:35:11 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8f97e51df97787225c1952e3d1bd094b01cae740
Cr-Commit-Position: refs/heads/master@{#300234}

Powered by Google App Engine
This is Rietveld 408576698