net/spdy/spdy_framer.cc - Issue 654253004: Update HTTP/2 DATA frame padding to 0x00.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_framer.cc

Issue 654253004: Update HTTP/2 DATA frame padding to 0x00. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master

Patch Set: Nit. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_framer.cc

diff --git a/net/spdy/spdy_framer.cc b/net/spdy/spdy_framer.cc

index fbe3675b750901032cba6a0d55169078292c6ec1..6affd7b9c198b2493929534fa782179bfcd2b26a 100644

--- a/net/spdy/spdy_framer.cc

+++ b/net/spdy/spdy_framer.cc

@@ -2314,7 +2314,7 @@ SpdySerializedFrame* SpdyFramer::SerializeData(

}

builder.WriteBytes(data_ir.data().data(), data_ir.data().length());

if (data_ir.padding_payload_len() > 0) {

- string padding = string(data_ir.padding_payload_len(), '0');

+ string padding(data_ir.padding_payload_len(), 0);

builder.WriteBytes(padding.data(), padding.length());

}

DCHECK_EQ(size_with_padding, builder.length());

« no previous file with comments | « no previous file | net/spdy/spdy_framer_test.cc » ('j') | no next file with comments »