Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6611)

Unified Diff: chrome/browser/profiles/gaia_info_update_service.h

Issue 654223009: Standardize usage of virtual/override/final in chrome/browser/profiles/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/gaia_info_update_service.h
diff --git a/chrome/browser/profiles/gaia_info_update_service.h b/chrome/browser/profiles/gaia_info_update_service.h
index 4e5c997d2089a346eabce50af1d2cf6252f3d485..03dc918d19cd37a73ec5aaa1d9974d2d13bb8558 100644
--- a/chrome/browser/profiles/gaia_info_update_service.h
+++ b/chrome/browser/profiles/gaia_info_update_service.h
@@ -24,7 +24,7 @@ class GAIAInfoUpdateService : public KeyedService,
public SigninManagerBase::Observer {
public:
explicit GAIAInfoUpdateService(Profile* profile);
- virtual ~GAIAInfoUpdateService();
+ ~GAIAInfoUpdateService() override;
// Updates the GAIA info for the profile associated with this instance.
virtual void Update();
@@ -33,17 +33,17 @@ class GAIAInfoUpdateService : public KeyedService,
static bool ShouldUseGAIAProfileInfo(Profile* profile);
// ProfileDownloaderDelegate:
- virtual bool NeedsProfilePicture() const override;
- virtual int GetDesiredImageSideLength() const override;
- virtual Profile* GetBrowserProfile() override;
- virtual std::string GetCachedPictureURL() const override;
- virtual void OnProfileDownloadSuccess(ProfileDownloader* downloader) override;
- virtual void OnProfileDownloadFailure(
+ bool NeedsProfilePicture() const override;
+ int GetDesiredImageSideLength() const override;
+ Profile* GetBrowserProfile() override;
+ std::string GetCachedPictureURL() const override;
+ void OnProfileDownloadSuccess(ProfileDownloader* downloader) override;
+ void OnProfileDownloadFailure(
ProfileDownloader* downloader,
ProfileDownloaderDelegate::FailureReason reason) override;
// Overridden from KeyedService:
- virtual void Shutdown() override;
+ void Shutdown() override;
private:
FRIEND_TEST_ALL_PREFIXES(GAIAInfoUpdateServiceTest, ScheduleUpdate);
@@ -52,11 +52,11 @@ class GAIAInfoUpdateService : public KeyedService,
void ScheduleNextUpdate();
// Overridden from SigninManagerBase::Observer:
- virtual void GoogleSigninSucceeded(const std::string& account_id,
- const std::string& username,
- const std::string& password) override;
- virtual void GoogleSignedOut(const std::string& account_id,
- const std::string& username) override;
+ void GoogleSigninSucceeded(const std::string& account_id,
+ const std::string& username,
+ const std::string& password) override;
+ void GoogleSignedOut(const std::string& account_id,
+ const std::string& username) override;
Profile* profile_;
scoped_ptr<ProfileDownloader> profile_image_downloader_;

Powered by Google App Engine
This is Rietveld 408576698