Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 654223004: Autofill: Allow forms to have multiple distinct CC number inputs. (Closed)

Created:
6 years, 2 months ago by Evan Stade
Modified:
6 years, 2 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Autofill: Allow forms to have multiple distinct CC number inputs. This broke when adding functionality to fill a single number across multiple fields. BUG=425256 Committed: https://crrev.com/517c358b493c9d8e5da6560524f989e1103d44c6 Cr-Commit-Position: refs/heads/master@{#300581}

Patch Set 1 #

Patch Set 2 : update comment, simplify check #

Total comments: 2

Patch Set 3 : better test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -25 lines) Patch
M components/autofill/core/browser/credit_card_field.cc View 1 4 chunks +8 lines, -20 lines 0 comments Download
M components/autofill/core/browser/credit_card_field_unittest.cc View 1 2 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Evan Stade
+isherman for review +brettw for FYI (this bug is why I was having trouble experimenting ...
6 years, 2 months ago (2014-10-20 20:23:35 UTC) #2
Ilya Sherman
LGTM % nit: https://codereview.chromium.org/654223004/diff/20001/components/autofill/core/browser/credit_card_field_unittest.cc File components/autofill/core/browser/credit_card_field_unittest.cc (right): https://codereview.chromium.org/654223004/diff/20001/components/autofill/core/browser/credit_card_field_unittest.cc#newcode485 components/autofill/core/browser/credit_card_field_unittest.cc:485: field_type_map_.end()); nit: Please use ASSERT_TRUE + ...
6 years, 2 months ago (2014-10-21 01:28:01 UTC) #3
Evan Stade
https://codereview.chromium.org/654223004/diff/20001/components/autofill/core/browser/credit_card_field_unittest.cc File components/autofill/core/browser/credit_card_field_unittest.cc (right): https://codereview.chromium.org/654223004/diff/20001/components/autofill/core/browser/credit_card_field_unittest.cc#newcode485 components/autofill/core/browser/credit_card_field_unittest.cc:485: field_type_map_.end()); On 2014/10/21 01:28:01, Ilya Sherman wrote: > nit: ...
6 years, 2 months ago (2014-10-21 18:38:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654223004/40001
6 years, 2 months ago (2014-10-21 18:39:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/27763)
6 years, 2 months ago (2014-10-21 19:46:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654223004/40001
6 years, 2 months ago (2014-10-21 21:52:47 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-22 00:30:03 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 00:34:30 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/517c358b493c9d8e5da6560524f989e1103d44c6
Cr-Commit-Position: refs/heads/master@{#300581}

Powered by Google App Engine
This is Rietveld 408576698