Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: components/autofill/core/browser/credit_card_field_unittest.cc

Issue 654223004: Autofill: Allow forms to have multiple distinct CC number inputs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: better test Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/core/browser/credit_card_field.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/credit_card_field_unittest.cc
diff --git a/components/autofill/core/browser/credit_card_field_unittest.cc b/components/autofill/core/browser/credit_card_field_unittest.cc
index fbf2f97a5073d5afe1352189eff40124d7b32bea..68719f2a4a67e05ae699983af2dedd44a19cf5c2 100644
--- a/components/autofill/core/browser/credit_card_field_unittest.cc
+++ b/components/autofill/core/browser/credit_card_field_unittest.cc
@@ -448,7 +448,7 @@ TEST_F(CreditCardFieldTest, ParseCreditCardNumberWithSplit) {
field_type_map_[ASCIIToUTF16("year6")]);
}
-TEST_F(CreditCardFieldTest, ParseCreditCardNumberWithInvalidSplit) {
+TEST_F(CreditCardFieldTest, ParseMultipleCreditCardNumbers) {
FormFieldData field;
field.form_control_type = "text";
@@ -460,8 +460,8 @@ TEST_F(CreditCardFieldTest, ParseCreditCardNumberWithInvalidSplit) {
field.name = ASCIIToUTF16("card_number");
list_.push_back(new AutofillField(field, ASCIIToUTF16("number2")));
- field.label = ASCIIToUTF16("Not Card Number");
- field.name = ASCIIToUTF16("not_card_number");
+ field.label = ASCIIToUTF16("Confirm Card Number");
+ field.name = ASCIIToUTF16("confirm_card_number");
list_.push_back(new AutofillField(field, ASCIIToUTF16("number3")));
field.label = ASCIIToUTF16("Exp Month");
@@ -479,10 +479,12 @@ TEST_F(CreditCardFieldTest, ParseCreditCardNumberWithInvalidSplit) {
ASSERT_TRUE(field_type_map_.find(ASCIIToUTF16("name1")) !=
field_type_map_.end());
EXPECT_EQ(CREDIT_CARD_NAME, field_type_map_[ASCIIToUTF16("name1")]);
- ASSERT_TRUE(field_type_map_.find(ASCIIToUTF16("number2")) ==
+ ASSERT_TRUE(field_type_map_.find(ASCIIToUTF16("number2")) !=
field_type_map_.end());
- ASSERT_TRUE(field_type_map_.find(ASCIIToUTF16("number3")) ==
+ EXPECT_EQ(CREDIT_CARD_NUMBER, field_type_map_[ASCIIToUTF16("number2")]);
+ ASSERT_TRUE(field_type_map_.find(ASCIIToUTF16("number3")) !=
field_type_map_.end());
+ EXPECT_EQ(CREDIT_CARD_NUMBER, field_type_map_[ASCIIToUTF16("number3")]);
ASSERT_TRUE(field_type_map_.find(ASCIIToUTF16("month4")) !=
field_type_map_.end());
EXPECT_EQ(CREDIT_CARD_EXP_MONTH, field_type_map_[ASCIIToUTF16("month4")]);
« no previous file with comments | « components/autofill/core/browser/credit_card_field.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698