Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 654153002: Change 'big5' to 'Big5' (Closed)

Created:
6 years, 2 months ago by jungshik at Google
Modified:
6 years, 2 months ago
Reviewers:
jsbell
CC:
chromium-reviews
Visibility:
Public.

Description

Change 'big5' to 'Big5' Some layout tests and chrome browser tests compare the encoding labels case-sensitively. Fixing them all takes a while. In the meantime, change the ICU alias table to use exactly what they expects (Big5). Also drop big5-hkscs from the alias for Big5 for now. They'll be unified in another CL. See the layout test failures for PS #2 at https://codereview.chromium.org/649413002 BUG=412053 TEST=browser_tests --gtest_filter=*ncoding* TEST=Layout tests : http/tests/misc/char-encod*, fast/encoding/* R=jsbell@chromium.org TBR=jsbell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=292476

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M android/icudtl.dat View Binary file 0 comments Download
M source/data/in/icudtl.dat View Binary file 0 comments Download
M source/data/mappings/convrtrs.txt View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
jsbell
lgtm
6 years, 2 months ago (2014-10-15 00:47:59 UTC) #2
jungshik at Google
6 years, 2 months ago (2014-10-15 18:53:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r292476 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698