Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 653973002: Be consistent about writing modes in boundingBoxForCompositingOverlapTest(). (Closed)

Created:
6 years, 2 months ago by mstensho (USE GERRIT)
Modified:
6 years, 2 months ago
Reviewers:
chrishtr
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Be consistent about writing modes in boundingBoxForCompositingOverlapTest(). Always use "physical" rectangles (i.e. flip for writing-mode). This is what boundingBoxForCompositing() already uses. BUG=423372 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183694

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
A LayoutTests/compositing/writing-mode-bt-overflow.html View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/compositing/writing-mode-bt-overflow-expected.html View 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/compositing/writing-mode-rl-overflow.html View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/compositing/writing-mode-rl-overflow-expected.html View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayer.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mstensho (USE GERRIT)
6 years, 2 months ago (2014-10-14 15:01:00 UTC) #2
chrishtr
lgtm
6 years, 2 months ago (2014-10-14 16:49:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653973002/1
6 years, 2 months ago (2014-10-14 16:50:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31748)
6 years, 2 months ago (2014-10-14 18:47:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653973002/1
6 years, 2 months ago (2014-10-14 19:01:58 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 19:57:43 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183694

Powered by Google App Engine
This is Rietveld 408576698