Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: Source/core/rendering/RenderLayer.h

Issue 653973002: Be consistent about writing modes in boundingBoxForCompositingOverlapTest(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/compositing/writing-mode-rl-overflow-expected.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 bool hitTest(const HitTestRequest&, const HitTestLocation&, HitTestResult&); 221 bool hitTest(const HitTestRequest&, const HitTestLocation&, HitTestResult&);
222 222
223 // Pass offsetFromRoot if known. 223 // Pass offsetFromRoot if known.
224 bool intersectsDamageRect(const LayoutRect& layerBounds, const LayoutRect& d amageRect, const RenderLayer* rootLayer, const LayoutPoint* offsetFromRoot = 0) const; 224 bool intersectsDamageRect(const LayoutRect& layerBounds, const LayoutRect& d amageRect, const RenderLayer* rootLayer, const LayoutPoint* offsetFromRoot = 0) const;
225 225
226 // Bounding box relative to some ancestor layer. Pass offsetFromRoot if know n. 226 // Bounding box relative to some ancestor layer. Pass offsetFromRoot if know n.
227 LayoutRect physicalBoundingBox(const RenderLayer* ancestorLayer, const Layou tPoint* offsetFromRoot = 0) const; 227 LayoutRect physicalBoundingBox(const RenderLayer* ancestorLayer, const Layou tPoint* offsetFromRoot = 0) const;
228 LayoutRect physicalBoundingBoxIncludingReflectionAndStackingChildren(const R enderLayer* ancestorLayer, const LayoutPoint& offsetFromRoot) const; 228 LayoutRect physicalBoundingBoxIncludingReflectionAndStackingChildren(const R enderLayer* ancestorLayer, const LayoutPoint& offsetFromRoot) const;
229 LayoutRect fragmentsBoundingBox(const RenderLayer* ancestorLayer) const; 229 LayoutRect fragmentsBoundingBox(const RenderLayer* ancestorLayer) const;
230 230
231 // FIXME: This function is inconsistent as to whether the returned rect has been flipped for writing mode. 231 LayoutRect boundingBoxForCompositingOverlapTest() const { return overlapBoun dsIncludeChildren() ? boundingBoxForCompositing() : flippedLogicalBoundingBox(); }
232 LayoutRect boundingBoxForCompositingOverlapTest() const { return overlapBoun dsIncludeChildren() ? boundingBoxForCompositing() : logicalBoundingBox(); }
233 232
234 // If true, this layer's children are included in its bounds for overlap tes ting. 233 // If true, this layer's children are included in its bounds for overlap tes ting.
235 // We can't rely on the children's positions if this layer has a filter that could have moved the children's pixels around. 234 // We can't rely on the children's positions if this layer has a filter that could have moved the children's pixels around.
236 bool overlapBoundsIncludeChildren() const { return hasFilter() && renderer() ->style()->filter().hasFilterThatMovesPixels(); } 235 bool overlapBoundsIncludeChildren() const { return hasFilter() && renderer() ->style()->filter().hasFilterThatMovesPixels(); }
237 236
238 enum CalculateBoundsOptions { 237 enum CalculateBoundsOptions {
239 ApplyBoundsChickenEggHacks, 238 ApplyBoundsChickenEggHacks,
240 DoNotApplyBoundsChickenEggHacks, 239 DoNotApplyBoundsChickenEggHacks,
241 }; 240 };
242 LayoutRect boundingBoxForCompositing(const RenderLayer* ancestorLayer = 0, C alculateBoundsOptions = DoNotApplyBoundsChickenEggHacks) const; 241 LayoutRect boundingBoxForCompositing(const RenderLayer* ancestorLayer = 0, C alculateBoundsOptions = DoNotApplyBoundsChickenEggHacks) const;
(...skipping 468 matching lines...) Expand 10 before | Expand all | Expand 10 after
711 710
712 } // namespace blink 711 } // namespace blink
713 712
714 #ifndef NDEBUG 713 #ifndef NDEBUG
715 // Outside the WebCore namespace for ease of invocation from gdb. 714 // Outside the WebCore namespace for ease of invocation from gdb.
716 void showLayerTree(const blink::RenderLayer*); 715 void showLayerTree(const blink::RenderLayer*);
717 void showLayerTree(const blink::RenderObject*); 716 void showLayerTree(const blink::RenderObject*);
718 #endif 717 #endif
719 718
720 #endif // RenderLayer_h 719 #endif // RenderLayer_h
OLDNEW
« no previous file with comments | « LayoutTests/compositing/writing-mode-rl-overflow-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698