Issue 6539011: Fix for Issue 73274: Printing causes view to scroll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6539011: Fix for Issue 73274: Printing causes view to scroll (Closed)

Created:
9 years, 10 months ago by Yuzo

Modified:
9 years, 7 months ago

Reviewers:
hamaji

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome

Visibility:
Public.

Fix for Issue 73274: Printing causes view to scroll Save and restore scroll offset when printing a page. This patch is applicable only after the patch for https://bugs.webkit.org/show_bug.cgi?id=54632 has been landed. This patch doesn't completely fix https://bugs.webkit.org/show_bug.cgi?id=52552 but the remaining issue is relatively minor. BUG=73274 TEST= Open a web page, scroll to the bottom, print, and observe the scroll position is not changed. See http://code.google.com/p/chromium/issues/detail?id=73274 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75689

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/renderer/print_web_view_helper.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/renderer/print_web_view_helper.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Looks good.