Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_view_mac.mm

Issue 653843002: Mac: Attach Extension NSViews to the view hierarchy before creating renderers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove DCHECK Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_view_mac.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm b/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm
index 44d12b982311cad702c4f7a6c3ba3f5c0321979b..7b62cfc680e4c7fadc805fa5b67af7094eed13af 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm
@@ -38,8 +38,9 @@ void ExtensionViewMac::WindowFrameChanged() {
render_view_host()->GetView()->WindowFrameChanged();
}
-void ExtensionViewMac::Init() {
- CreateWidgetHostView();
+void ExtensionViewMac::CreateWidgetHostViewIn(gfx::NativeView superview) {
+ [superview addSubview:GetNativeView()];
+ extension_host_->CreateRenderViewSoon();
}
Browser* ExtensionViewMac::GetBrowser() {
@@ -89,10 +90,6 @@ content::RenderViewHost* ExtensionViewMac::render_view_host() const {
return extension_host_->render_view_host();
}
-void ExtensionViewMac::CreateWidgetHostView() {
- extension_host_->CreateRenderViewSoon();
-}
-
void ExtensionViewMac::ShowIfCompletelyLoaded() {
// We wait to show the ExtensionView until it has loaded, and the view has
// actually been created. These can happen in different orders.
« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_view_mac.h ('k') | chrome/browser/ui/views/extensions/extension_view_views.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698