chrome/browser/ui/cocoa/extensions/extension_view_mac.h - Issue 653843002: Mac: Attach Extension NSViews to the view hierarchy before creating renderers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_view_mac.h

Issue 653843002: Mac: Attach Extension NSViews to the view hierarchy before creating renderers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove DCHECK Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_view_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_view_mac.h

diff --git a/chrome/browser/ui/cocoa/extensions/extension_view_mac.h b/chrome/browser/ui/cocoa/extensions/extension_view_mac.h

index ab2dc9ddb95743683563c91f43886dc879f80014..a67da2914b17e400cad11fc06543b3175257fa96 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_view_mac.h

+++ b/chrome/browser/ui/cocoa/extensions/extension_view_mac.h

@@ -53,8 +53,10 @@ class ExtensionViewMac : public extensions::ExtensionView {

// Informs the view that its containing window's frame changed.

void WindowFrameChanged();

+ // Create the host view, adding it as a subview of |superview|.

+ void CreateWidgetHostViewIn(gfx::NativeView superview);

// extensions::ExtensionView:

- void Init() override;

Browser* GetBrowser() override;

gfx::NativeView GetNativeView() override;

void ResizeDueToAutoResize(const gfx::Size& new_size) override;

@@ -67,8 +69,6 @@ class ExtensionViewMac : public extensions::ExtensionView {

private:

content::RenderViewHost* render_view_host() const;

- void CreateWidgetHostView();

// We wait to show the ExtensionView until several things have loaded.

void ShowIfCompletelyLoaded();