chrome/browser/extensions/extension_view_host.cc - Issue 653843002: Mac: Attach Extension NSViews to the view hierarchy before creating renderers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_view_host.cc

Issue 653843002: Mac: Attach Extension NSViews to the view hierarchy before creating renderers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove DCHECK Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_view.h ('k') | chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_view_host.cc

diff --git a/chrome/browser/extensions/extension_view_host.cc b/chrome/browser/extensions/extension_view_host.cc

index 40e88d6c4e45242f0ed00ee3d94659205e0870e1..ee79ebafe31f5ac45f5017955c3c299640a33b16 100644

--- a/chrome/browser/extensions/extension_view_host.cc

+++ b/chrome/browser/extensions/extension_view_host.cc

@@ -77,7 +77,6 @@ ExtensionViewHost::~ExtensionViewHost() {

void ExtensionViewHost::CreateView(Browser* browser) {

view_ = CreateExtensionView(this, browser);

- view_->Init();

}

void ExtensionViewHost::SetAssociatedWebContents(WebContents* web_contents) {

« no previous file with comments | « chrome/browser/extensions/extension_view.h ('k') | chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm » ('j') | no next file with comments »