chrome/browser/extensions/extension_view.h - Issue 653843002: Mac: Attach Extension NSViews to the view hierarchy before creating renderers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_view.h

Issue 653843002: Mac: Attach Extension NSViews to the view hierarchy before creating renderers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove DCHECK Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_view.h

diff --git a/chrome/browser/extensions/extension_view.h b/chrome/browser/extensions/extension_view.h

index e974d0973b5a875b7dca12bc6be2e78a238c1fbc..f8a5390fba96d7f3eca28ff81c3ca875669fb9ec 100644

--- a/chrome/browser/extensions/extension_view.h

+++ b/chrome/browser/extensions/extension_view.h

@@ -25,9 +25,6 @@ class ExtensionView {

public:

virtual ~ExtensionView() {}

- // Initialize the view, once a newly created view has been set in the host.

- virtual void Init() = 0;

// If attached to a Browser (e.g. popups), the Browser it is attached to.

virtual Browser* GetBrowser() = 0;

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_view_host.cc » ('j') | no next file with comments »