Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(56)

Issue 6538046: Add vpd 2.0 log file in in chrome://system (Closed)

Created:
8 years, 6 months ago by Louis
Modified:
8 years ago
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Add vpd 2.0 log file in chrome://system VPD (Vital Product Data) are written into BIOS flash during factory. It contains machine-specific information, e.g., mother board serial number, MAC address, 3G module serial number... Those information are important when user sends machine back to service cent The log file is generated in session_manager.sh (see http://codereview.chromium.org/6543005). Will commit this CL after that CL. Change-Id: Idd73b3fecf060a458a18fc8792ca2f31e21e6ac1 BUG=chromos-partner:1462 TEST=Tested on Mario. VPD info show in chrome://system. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c93e688

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M etc/sys_log_utils.lst View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Chris Masone
this change LGTM, though I would like to see the upstart job for generating this ...
8 years, 5 months ago (2011-02-24 06:10:32 UTC) #1
Louis
No problem, Chris. I've created the CL as you suggested: http://codereview.chromium.org/6581026/ Thanks, submitting this CL. ...
8 years, 5 months ago (2011-02-24 10:29:35 UTC) #2
Louis
8 years, 5 months ago (2011-02-24 11:13:08 UTC) #3
Sorry, I didn't sort the entry with alphabet order. Send another CL
(http://codereview.chromium.org/6580029). Please kindly review for me.

On 2011/02/24 10:29:35, Louis wrote:
> No problem, Chris. I've created the CL as you suggested:
> http://codereview.chromium.org/6581026/
> 
> Thanks, submitting this CL.
> 
> On 2011/02/24 06:10:32, Chris Masone wrote:
> > this change LGTM, though I would like to see the upstart job for generating
> this
> > file, and the vpd dep added to chromeos-init.  Also, add jrbarnette to the
> > upstart job CL as well. He's been doing a big refactor of the upstart
scripts
> > and will be helpful.

Powered by Google App Engine
This is Rietveld 408576698