Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7213)

Unified Diff: chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc
diff --git a/chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc b/chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc
index b631f1c5c05b8b96748befd6f320970831240f35..adf85f761523a166fd0ac4649e453402f17573eb 100644
--- a/chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc
+++ b/chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc
@@ -30,19 +30,15 @@ class UIOverridesHandler::ManifestPermissionImpl : public ManifestPermission {
: override_bookmarks_ui_permission_(override_bookmarks_ui_permission) {}
// extensions::ManifestPermission overrides.
- virtual std::string name() const override {
- return manifest_keys::kUIOverride;
- }
+ std::string name() const override { return manifest_keys::kUIOverride; }
- virtual std::string id() const override {
- return name();
- }
+ std::string id() const override { return name(); }
- virtual bool HasMessages() const override {
+ bool HasMessages() const override {
return override_bookmarks_ui_permission_;
}
- virtual PermissionMessages GetMessages() const override {
+ PermissionMessages GetMessages() const override {
PermissionMessages result;
if (override_bookmarks_ui_permission_) {
result.push_back(PermissionMessage(
@@ -53,17 +49,16 @@ class UIOverridesHandler::ManifestPermissionImpl : public ManifestPermission {
return result;
}
- virtual bool FromValue(const base::Value* value) override {
+ bool FromValue(const base::Value* value) override {
return value && value->GetAsBoolean(&override_bookmarks_ui_permission_);
}
- virtual scoped_ptr<base::Value> ToValue() const override {
+ scoped_ptr<base::Value> ToValue() const override {
return scoped_ptr<base::Value>(
new base::FundamentalValue(override_bookmarks_ui_permission_)).Pass();
}
- virtual ManifestPermission* Diff(const ManifestPermission* rhs) const
- override {
+ ManifestPermission* Diff(const ManifestPermission* rhs) const override {
const ManifestPermissionImpl* other =
static_cast<const ManifestPermissionImpl*>(rhs);
@@ -72,8 +67,7 @@ class UIOverridesHandler::ManifestPermissionImpl : public ManifestPermission {
!other->override_bookmarks_ui_permission_)).release();
}
- virtual ManifestPermission* Union(const ManifestPermission* rhs) const
- override {
+ ManifestPermission* Union(const ManifestPermission* rhs) const override {
const ManifestPermissionImpl* other =
static_cast<const ManifestPermissionImpl*>(rhs);
@@ -82,8 +76,7 @@ class UIOverridesHandler::ManifestPermissionImpl : public ManifestPermission {
other->override_bookmarks_ui_permission_)).release();
}
- virtual ManifestPermission* Intersect(const ManifestPermission* rhs) const
- override {
+ ManifestPermission* Intersect(const ManifestPermission* rhs) const override {
const ManifestPermissionImpl* other =
static_cast<const ManifestPermissionImpl*>(rhs);

Powered by Google App Engine
This is Rietveld 408576698