Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 653613002: [DevTools] Inject element into toolbox window, do not load modules there. (Closed)

Created:
6 years, 2 months ago by dgozman
Modified:
6 years, 2 months ago
Reviewers:
pfeldman
CC:
blink-reviews, vsevik+blink_chromium.org, caseq+blink_chromium.org, arv+blink, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, loislo+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, blink-reviews-bindings_chromium.org, Inactive, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Inject element into toolbox window, do not load modules there. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184193

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : second attempt #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -50 lines) Patch
M Source/bindings/core/v8/custom/V8InspectorFrontendHostCustom.cpp View 1 2 2 chunks +17 lines, -7 lines 0 comments Download
M Source/core/inspector/InspectorFrontendHost.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/host/InspectorFrontendHost.js View 1 2 3 chunks +8 lines, -2 lines 0 comments Download
M Source/devtools/front_end/main/AdvancedApp.js View 1 chunk +15 lines, -5 lines 0 comments Download
M Source/devtools/front_end/toolbox.json View 2 chunks +0 lines, -16 lines 0 comments Download
M Source/devtools/front_end/toolbox/ToolboxDelegate.js View 1 chunk +7 lines, -3 lines 0 comments Download
M Source/devtools/front_end/toolbox_bootstrap/Toolbox.js View 1 2 1 chunk +4 lines, -14 lines 0 comments Download
M Source/devtools/front_end/toolbox_bootstrap/module.json View 1 chunk +3 lines, -1 line 0 comments Download
M Source/devtools/front_end/ui/ContextMenu.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
dgozman
Take a look please.
6 years, 2 months ago (2014-10-13 12:05:17 UTC) #2
pfeldman
lgtm
6 years, 2 months ago (2014-10-13 12:49:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653613002/150001
6 years, 2 months ago (2014-10-14 12:06:58 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:150001) as 183669
6 years, 2 months ago (2014-10-14 13:08:25 UTC) #6
dgozman
A revert of this CL (patchset #2 id:150001) has been created in https://codereview.chromium.org/660503002/ by dgozman@chromium.org. ...
6 years, 2 months ago (2014-10-15 12:57:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653613002/170001
6 years, 2 months ago (2014-10-22 13:11:49 UTC) #9
commit-bot: I haz the power
Failed to apply patch for Source/devtools/front_end/ui/ContextMenu.js: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 2 months ago (2014-10-22 13:12:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653613002/190001
6 years, 2 months ago (2014-10-22 13:29:58 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 15:40:46 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:190001) as 184193

Powered by Google App Engine
This is Rietveld 408576698