Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2590)

Unified Diff: Source/devtools/front_end/main/AdvancedApp.js

Issue 653613002: [DevTools] Inject element into toolbox window, do not load modules there. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebased Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/host/InspectorFrontendHost.js ('k') | Source/devtools/front_end/toolbox.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/main/AdvancedApp.js
diff --git a/Source/devtools/front_end/main/AdvancedApp.js b/Source/devtools/front_end/main/AdvancedApp.js
index 2dae0138fb781af5e8988870e554aafd8f32c03e..d03bb0ac3c8b32df8a4395944a25cc7acf602f28 100644
--- a/Source/devtools/front_end/main/AdvancedApp.js
+++ b/Source/devtools/front_end/main/AdvancedApp.js
@@ -88,16 +88,26 @@ WebInspector.AdvancedApp.prototype = {
},
/**
- * @param {!WebInspector.ResponsiveDesignView} responsiveDesignView
- * @param {!WebInspector.InspectedPagePlaceholder} placeholder
+ * @param {!Element} rootElement
+ * @override
*/
- toolboxLoaded: function(responsiveDesignView, placeholder)
+ toolboxLoaded: function(rootElement)
{
- this._toolboxResponsiveDesignView = responsiveDesignView;
- placeholder.addEventListener(WebInspector.InspectedPagePlaceholder.Events.Update, this._onSetInspectedPageBounds.bind(this, true));
+ var inspectedPagePlaceholder = new WebInspector.InspectedPagePlaceholder();
+ inspectedPagePlaceholder.addEventListener(WebInspector.InspectedPagePlaceholder.Events.Update, this._onSetInspectedPageBounds.bind(this, true));
+ this._toolboxResponsiveDesignView = new WebInspector.ResponsiveDesignView(inspectedPagePlaceholder);
+ this._toolboxResponsiveDesignView.show(rootElement);
this._updatePageResizer();
},
+ /**
+ * @return {!InspectorFrontendHostAPI}
+ */
+ inspectorFrontendHost: function()
+ {
+ return window.InspectorFrontendHost;
+ },
+
_updatePageResizer: function()
{
if (this._isDocked())
« no previous file with comments | « Source/devtools/front_end/host/InspectorFrontendHost.js ('k') | Source/devtools/front_end/toolbox.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698