Issue 65343003: Make metadata state local in the WebVTT parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 65343003: Make metadata state local in the WebVTT parser (Closed)

Created:
7 years, 1 month ago by fs

Modified:
7 years, 1 month ago

Reviewers:
Nate Chapin, jochen (gone - plz use gerrit)

CC:
blink-reviews, dglazkov+blink, nessy, vcarbune.chromium, philipj_slow, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Make metadata state local in the WebVTT parser The members m_currentHeaderName and m_currentHeaderValue are only used within the scope of WebVTTParser::collectMetadataHeader, so there's no need to keep them in instance scope. Make them local to said method, and pass the value explicitly to its users. BUG=305317 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161922

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -11 lines)			Patch
	M	Source/core/html/track/WebVTTParser.h	View		1 chunk	+1 line, -4 lines	0 comments	Download
	M	Source/core/html/track/WebVTTParser.cpp	View		2 chunks	+7 lines, -7 lines	0 comments	Download