Source/core/html/track/WebVTTParser.h - Issue 65343003: Make metadata state local in the WebVTT parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/WebVTTParser.h

Issue 65343003: Make metadata state local in the WebVTT parser (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/track/WebVTTParser.h

diff --git a/Source/core/html/track/WebVTTParser.h b/Source/core/html/track/WebVTTParser.h

index d6a6573a9258bcab24b923571e4af524fa7938d5..27e026883ecc54fd9dd363014b8a2dc3672f897c 100644

--- a/Source/core/html/track/WebVTTParser.h

+++ b/Source/core/html/track/WebVTTParser.h

@@ -130,13 +130,10 @@ private:

void resetCueValues();

void collectMetadataHeader(const String&);

- void createNewRegion();

+ void createNewRegion(const String& headerValue);

void skipWhiteSpace(const String&, unsigned*);

- String m_currentHeaderName;

- String m_currentHeaderValue;

BufferedLineReader m_lineReader;

RefPtr<TextResourceDecoder> m_decoder;

String m_currentId;

« no previous file with comments | « no previous file | Source/core/html/track/WebVTTParser.cpp » ('j') | no next file with comments »