Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 653393003: Cleanup: Turn GrReducedClip into a class with a static function. (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 1 month ago
CC:
reviews_skia.org, robertphillips
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Cleanup: Turn GrReducedClip into a class with a static function. Clean up namespace usage. Similar to what was done in https://skia.googlesource.com/skia/+/a5414c4a8efc3119ee20fcee96c0bf68a04909c7 BUG=None TEST=None R=bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/bf54e49e30cdc92f9ce3f336cc48cf6b236ddeab

Patch Set 1 #

Total comments: 7

Patch Set 2 : fix very long lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -227 lines) Patch
M src/gpu/GrClipMaskManager.cpp View 1 12 chunks +25 lines, -26 lines 0 comments Download
M src/gpu/GrReducedClip.h View 1 2 chunks +33 lines, -32 lines 0 comments Download
M src/gpu/GrReducedClip.cpp View 1 14 chunks +157 lines, -169 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tfarina
ptal. https://codereview.chromium.org/653393003/diff/1/src/gpu/GrReducedClip.cpp File src/gpu/GrReducedClip.cpp (right): https://codereview.chromium.org/653393003/diff/1/src/gpu/GrReducedClip.cpp#newcode326 src/gpu/GrReducedClip.cpp:326: void GrReducedClip::ReduceClipStack(const SkClipStack& stack, Sorry for this big ...
6 years, 2 months ago (2014-10-23 04:03:08 UTC) #1
robertphillips
lgtm + some formatting nits https://codereview.chromium.org/653393003/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): https://codereview.chromium.org/653393003/diff/1/src/gpu/GrClipMaskManager.cpp#newcode737 src/gpu/GrClipMaskManager.cpp:737: overlength line ? https://codereview.chromium.org/653393003/diff/1/src/gpu/GrReducedClip.cpp ...
6 years, 2 months ago (2014-10-23 12:24:18 UTC) #3
tfarina
https://codereview.chromium.org/653393003/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): https://codereview.chromium.org/653393003/diff/1/src/gpu/GrClipMaskManager.cpp#newcode737 src/gpu/GrClipMaskManager.cpp:737: On 2014/10/23 12:24:17, robertphillips wrote: > overlength line ? ...
6 years, 1 month ago (2014-10-24 00:38:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653393003/40001
6 years, 1 month ago (2014-10-24 00:39:20 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-24 00:47:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as bf54e49e30cdc92f9ce3f336cc48cf6b236ddeab

Powered by Google App Engine
This is Rietveld 408576698