Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 653293004: Made the 'Licenses' link in the App Info dialog open all licenses (Closed)

Created:
6 years, 2 months ago by sashab
Modified:
6 years, 2 months ago
Reviewers:
benwells
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Made the 'Licenses' link in the App Info dialog open all licenses Currently, the 'Licenses' link in the App Info dialog only opens the license page of the first shared module the app uses. Changed it to open all licenses for shared modules that provide them in separate tabs, then close the dialog. BUG=422116 Committed: https://crrev.com/c4e6c22a646d0d86e8c7f828f7855ac537ac79a2 Cr-Commit-Position: refs/heads/master@{#300660}

Patch Set 1 #

Patch Set 2 : Small bugfix for shared modules with no license page #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc View 1 3 chunks +20 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sashab
6 years, 2 months ago (2014-10-20 02:39:08 UTC) #2
benwells
lgtm
6 years, 2 months ago (2014-10-21 04:37:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653293004/20001
6 years, 2 months ago (2014-10-22 09:36:38 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-22 10:42:32 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 10:43:15 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4e6c22a646d0d86e8c7f828f7855ac537ac79a2
Cr-Commit-Position: refs/heads/master@{#300660}

Powered by Google App Engine
This is Rietveld 408576698