chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.h - Issue 653293004: Made the 'Licenses' link in the App Info dialog open all licenses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.h

Issue 653293004: Made the 'Licenses' link in the App Info dialog open all licenses (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small bugfix for shared modules with no license page Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.h

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.h b/chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.h

index 566c11d313f2d8c0ddf811bfadfffa58edba1b9e..cdbc73aac24e084f13e51bcbaa01875be35ae8ea 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.h

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.h

@@ -58,9 +58,9 @@ class AppInfoHeaderPanel : public AppInfoPanel,

// CanDisplayLicenses() returns true.

void DisplayLicenses();

bool CanDisplayLicenses() const;

- const GURL& GetLicenseUrl() const;

+ const std::vector<GURL> GetLicenseUrls() const;

- // Opens the given URL in a new browser tab, and closes the dialog.

+ // Opens the given URL in a new browser tab.

void OpenLink(const GURL& url);

// UI elements on the dialog. Elements are NULL if they are not displayed.

« no previous file with comments | « no previous file | chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc » ('j') | no next file with comments »