Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 653283007: Tests for CL 647933003. (Closed)

Created:
6 years, 2 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 1 month ago
CC:
darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Tests for CL 647933003. BUG=424453 Committed: https://crrev.com/bed415634f57baf1e74d94d133b251fab330919e Cr-Commit-Position: refs/heads/master@{#302374}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix win8 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -5 lines) Patch
M content/browser/screen_orientation/screen_orientation_browsertest.cc View 1 2 2 chunks +26 lines, -5 lines 0 comments Download
A content/test/data/screen_orientation/detached-iframe.html View 1 chunk +12 lines, -0 lines 0 comments Download
A content/test/data/screen_orientation/screen_orientation_use_after_detach.html View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
mlamouri (slow - plz ping)
This is the tests for https://codereview.chromium.org/647933003 The tests are private for now because the fix ...
6 years, 2 months ago (2014-10-22 13:07:20 UTC) #2
Mike West
LGTM, but you'll need a content/ OWNER. jochen@ for instance.
6 years, 2 months ago (2014-10-22 13:16:39 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-22 15:24:01 UTC) #5
Mike West
Ping. I assume you can land this now?
6 years, 1 month ago (2014-10-27 10:18:01 UTC) #6
mlamouri (slow - plz ping)
On 2014/10/27 10:18:01, Mike West wrote: > Ping. I assume you can land this now? ...
6 years, 1 month ago (2014-10-28 04:55:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653283007/1
6 years, 1 month ago (2014-10-31 18:13:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/86819) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/76429) android_aosp ...
6 years, 1 month ago (2014-10-31 18:17:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653283007/20001
6 years, 1 month ago (2014-10-31 18:48:18 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/25133)
6 years, 1 month ago (2014-10-31 20:04:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653283007/20001
6 years, 1 month ago (2014-10-31 21:19:11 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/25220)
6 years, 1 month ago (2014-10-31 23:49:24 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653283007/40001
6 years, 1 month ago (2014-11-01 00:11:58 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-01 01:10:58 UTC) #22
commit-bot: I haz the power
6 years, 1 month ago (2014-11-01 01:11:46 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bed415634f57baf1e74d94d133b251fab330919e
Cr-Commit-Position: refs/heads/master@{#302374}

Powered by Google App Engine
This is Rietveld 408576698