Issue 647933003: Disconnect from WebScreenOrientationClient when frame is detached.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 647933003: Disconnect from WebScreenOrientationClient when frame is detached. (Closed)

Created:
6 years, 2 months ago by mlamouri (slow - plz ping)

Modified:
6 years, 2 months ago

Reviewers:
Mike West

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Disconnect from WebScreenOrientationClient when frame is detached. BUG=424453 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184185

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
	M	Source/modules/screen_orientation/ScreenOrientationController.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	Source/modules/screen_orientation/ScreenOrientationController.cpp	View		2 chunks	+11 lines, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

mlamouri (slow - plz ping)

Unfortunately, it requires browser tests because the WebScreenOrientationClient isn't the same in the ContentShell and ...

6 years, 2 months ago (2014-10-22 13:05:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647933003/1

6 years, 2 months ago (2014-10-22 13:14:47 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-22 14:22:12 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 184185