Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 653283003: MeterRole was missed in computeAccessibilityIgnored() (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 2 months ago
Reviewers:
dmazzoni, Mike West
CC:
blink-reviews, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

MeterRole was missed in computeAccessibilityIgnored() In this CL https://codereview.chromium.org/652663003/ MeterRole is not added to computeAccessibilityIgnored(). So, adding that change in this CL. BUG=421376 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183778

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/core/accessibility/AXRenderObject.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
shreeramk
Please review. Thanks :)
6 years, 2 months ago (2014-10-15 08:42:42 UTC) #2
dmazzoni
lgtm
6 years, 2 months ago (2014-10-15 23:26:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653283003/1
6 years, 2 months ago (2014-10-15 23:27:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/58981)
6 years, 2 months ago (2014-10-16 00:02:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653283003/1
6 years, 2 months ago (2014-10-16 02:37:08 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 02:37:47 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183778

Powered by Google App Engine
This is Rietveld 408576698