Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: Source/core/accessibility/AXRenderObject.cpp

Issue 653283003: MeterRole was missed in computeAccessibilityIgnored() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 701 matching lines...) Expand 10 before | Expand all | Expand 10 after
712 712
713 if (roleValue() == FigcaptionRole) 713 if (roleValue() == FigcaptionRole)
714 return false; 714 return false;
715 715
716 if (roleValue() == FigureRole) 716 if (roleValue() == FigureRole)
717 return false; 717 return false;
718 718
719 if (roleValue() == DetailsRole) 719 if (roleValue() == DetailsRole)
720 return false; 720 return false;
721 721
722 if (roleValue() == MeterRole)
723 return false;
724
722 // if this element has aria attributes on it, it should not be ignored. 725 // if this element has aria attributes on it, it should not be ignored.
723 if (supportsARIAAttributes()) 726 if (supportsARIAAttributes())
724 return false; 727 return false;
725 728
726 // <span> tags are inline tags and not meant to convey information if they h ave no other aria 729 // <span> tags are inline tags and not meant to convey information if they h ave no other aria
727 // information on them. If we don't ignore them, they may emit signals expec ted to come from 730 // information on them. If we don't ignore them, they may emit signals expec ted to come from
728 // their parent. In addition, because included spans are GroupRole objects, and GroupRole 731 // their parent. In addition, because included spans are GroupRole objects, and GroupRole
729 // objects are often containers with meaningful information, the inclusion o f a span can have 732 // objects are often containers with meaningful information, the inclusion o f a span can have
730 // the side effect of causing the immediate parent accessible to be ignored. This is especially 733 // the side effect of causing the immediate parent accessible to be ignored. This is especially
731 // problematic for platforms which have distinct roles for textual block ele ments. 734 // problematic for platforms which have distinct roles for textual block ele ments.
(...skipping 1648 matching lines...) Expand 10 before | Expand all | Expand 10 after
2380 if (label && label->renderer()) { 2383 if (label && label->renderer()) {
2381 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect(); 2384 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect();
2382 result.unite(labelRect); 2385 result.unite(labelRect);
2383 } 2386 }
2384 } 2387 }
2385 2388
2386 return result; 2389 return result;
2387 } 2390 }
2388 2391
2389 } // namespace blink 2392 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698