Add BenchmarkOptionsTest. Move smoke test to benchmark_smoke_unittest

Move benchmark_unittest.py to benchmark_smoke_unittest.py
Add benchmark_unittest.py that tests benchmark options.

BUG=422596
Committed: https://crrev.com/e68c7cde5e8169649631ebe247d20447261d69f7
Cr-Commit-Position: refs/heads/master@{#299740}

[slamm, 2014-10-14 23:04:50]

slamm@chromium.org changed reviewers:
+ dtu@chromium.org, nednguyen@google.com

[nednguyen, 2014-10-14 23:08:33]

On 2014/10/14 23:04:55, slamm wrote:

It's worth adding to the description that benchmark_unittest runs its tests
against all benchmarks, whereas benchmark_smoke_test only runs against a subset
of them.

[dtu, 2014-10-14 23:14:42]

lgtm % nit

https://codereview.chromium.org/653233002/diff/1/tools/perf/benchmarks/benchm...
File tools/perf/benchmarks/benchmark_unittest.py (right):

https://codereview.chromium.org/653233002/diff/1/tools/perf/benchmarks/benchm...
tools/perf/benchmarks/benchmark_unittest.py:18: return
os.path.join(path.GetChromiumSrcDir(), 'tools', 'perf', *subdirs)
I prefer having this defined relative to __file__ than src/

[slamm, 2014-10-14 23:19:45]

Add comments regards what set of benchmarks is used.

[slamm, 2014-10-14 23:22:23]

Have |_GetPerfDir| use __file__ instead of GetChromiumSrcDir

[slamm, 2014-10-14 23:23:48]

On 2014/10/14 23:08:33, nednguyen wrote:
> On 2014/10/14 23:04:55, slamm wrote:
> 
> It's worth adding to the description that benchmark_unittest runs its tests
> against all benchmarks, whereas benchmark_smoke_test only runs against a
subset
> of them.

Done.

[slamm, 2014-10-14 23:23:56]

https://codereview.chromium.org/653233002/diff/1/tools/perf/benchmarks/benchm...
File tools/perf/benchmarks/benchmark_unittest.py (right):

https://codereview.chromium.org/653233002/diff/1/tools/perf/benchmarks/benchm...
tools/perf/benchmarks/benchmark_unittest.py:18: return
os.path.join(path.GetChromiumSrcDir(), 'tools', 'perf', *subdirs)
On 2014/10/14 23:14:41, dtu wrote:
> I prefer having this defined relative to __file__ than src/

Done.

[slamm, 2014-10-15 18:10:58]

The CQ bit was checked by slamm@chromium.org

[commit-bot: I haz the power, 2014-10-15 18:13:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/653233002/40001

[commit-bot: I haz the power, 2014-10-15 19:26:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-15 19:27:24]

Patchset 3 (id:??) landed as
https://crrev.com/e68c7cde5e8169649631ebe247d20447261d69f7
Cr-Commit-Position: refs/heads/master@{#299740}