Add BenchmarkOptionsTest. Move smoke test to benchmark_smoke_unittest

tools/perf/benchmarks/benchmark_smoke_unittest.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-"""Run the first page of every benchmark that has a composable measurement.
+"""Run the first page of one benchmark for every module.
 
-Ideally this test would be comprehensive, but the above serves as a
-kind of smoke test.
+Only benchmarks that have a composable measurement are included.
+Ideally this test would be comprehensive, however, running one page
+of every benchmark would run impractically long.
 """
 
 import os
 import unittest
 
 from telemetry import benchmark as benchmark_module
 from telemetry.core import discover
 from telemetry.page import page_test
 from telemetry.unittest import options_for_unittests
 from telemetry.unittest import progress_reporter
@@ skipping 43 matching lines @@
 
 
 def load_tests(_, _2, _3):
   suite = progress_reporter.TestSuite()
 
   benchmarks_dir = os.path.dirname(__file__)
   top_level_dir = os.path.dirname(benchmarks_dir)
   measurements_dir = os.path.join(top_level_dir, 'measurements')
 
   all_measurements = discover.DiscoverClasses(
-      measurements_dir, top_level_dir, page_test.PageTest,
-      pattern='*.py').values()
+      measurements_dir, top_level_dir, page_test.PageTest).values()
+  # Using the default of |index_by_class_name=False| means that if a module
+  # has multiple benchmarks, only the last one is returned.
   all_benchmarks = discover.DiscoverClasses(
       benchmarks_dir, top_level_dir, benchmark_module.Benchmark,
-      pattern='*.py').values()
+      index_by_class_name=False).values()
   for benchmark in all_benchmarks:
     if benchmark.PageTestClass() not in all_measurements:
       # If the benchmark is not in measurements, then it is not composable.
       # Ideally we'd like to test these as well, but the non-composable
       # benchmarks are usually long-running benchmarks.
       continue
 
     # TODO(tonyg): Smoke doesn't work with session_restore yet.
     if benchmark.Name().startswith('session_restore'):
       continue
 
     if hasattr(benchmark, 'generated_profile_archive'):
       # We'd like to test these, but don't know how yet.
       continue
 
     class BenchmarkSmokeTest(unittest.TestCase):
       pass
     setattr(BenchmarkSmokeTest, benchmark.Name(), SmokeTestGenerator(benchmark))
     suite.addTest(BenchmarkSmokeTest(benchmark.Name()))
 
   return suite