Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1641)

Unified Diff: Source/web/WebDocument.cpp

Issue 653223002: Navigation transitions (web to native app): Revert exit transition (Blink side) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: add tests Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebDocument.cpp
diff --git a/Source/web/WebDocument.cpp b/Source/web/WebDocument.cpp
index d5cc1b13e5b84d82bdf21191c3b0ae85cdc08159..087b67759fc2ad49cae757890162d9f388ba48bc 100644
--- a/Source/web/WebDocument.cpp
+++ b/Source/web/WebDocument.cpp
@@ -289,13 +289,34 @@ void WebDocument::setIsTransitionDocument()
unwrap<Document>()->setIsTransitionDocument();
}
+// TODO(zhenw): This will be removed once the Chrome side implementation is done
void WebDocument::beginExitTransition(const WebString& cssSelector)
{
RefPtrWillBeRawPtr<Document> document = unwrap<Document>();
- document->hideTransitionElements(cssSelector);
+ document->onTransitionElementOpacity(cssSelector, 0.0);
document->styleEngine()->enableExitTransitionStylesheets();
}
+void WebDocument::beginExitTransition(const WebString& cssSelector, const bool exitToActivity)
+{
+ RefPtrWillBeRawPtr<Document> document = unwrap<Document>();
+ if (!exitToActivity)
+ document->onTransitionElementOpacity(cssSelector, 0.0);
+ document->styleEngine()->enableExitTransitionStylesheets();
+}
+
+void WebDocument::revertExitTransition()
+{
+ RefPtrWillBeRawPtr<Document> document = unwrap<Document>();
+ document->styleEngine()->disableExitTransitionStylesheets();
+}
+
+void WebDocument::onTransitionElementOpacity(const WebString& cssSelector, const double opacity)
+{
+ RefPtrWillBeRawPtr<Document> document = unwrap<Document>();
+ document->onTransitionElementOpacity(cssSelector, opacity);
esprehn 2014/10/15 18:01:26 onFoo is not a verb.
Zhen Wang 2014/10/15 19:50:58 Done.
+}
+
WebAXObject WebDocument::accessibilityObject() const
{
const Document* document = constUnwrap<Document>();

Powered by Google App Engine
This is Rietveld 408576698