Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: Source/core/html/HTMLLinkElement.cpp

Issue 653223002: Navigation transitions (web to native app): Revert exit transition (Blink side) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: add tests Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLLinkElement.cpp
diff --git a/Source/core/html/HTMLLinkElement.cpp b/Source/core/html/HTMLLinkElement.cpp
index 93bc16b9007e9dd898acf7c74176ffd66054762e..dbbe2a31f98cda8ec1e973ad9e676a5d9d495d04 100644
--- a/Source/core/html/HTMLLinkElement.cpp
+++ b/Source/core/html/HTMLLinkElement.cpp
@@ -259,6 +259,14 @@ void HTMLLinkElement::enableIfExitTransitionStyle()
}
}
+void HTMLLinkElement::disableIfExitTransitionStyle()
+{
+ if (m_relAttribute.isTransitionExitingStylesheet()) {
+ if (LinkStyle* link = linkStyle())
+ link->setDisabledState(true);
+ }
+}
+
Node::InsertionNotificationRequest HTMLLinkElement::insertedInto(ContainerNode* insertionPoint)
{
if (insertionPoint->inDocument()) {
@@ -659,7 +667,10 @@ void LinkStyle::setDisabledState(bool disabled)
process();
} else {
// FIXME: We don't have enough knowledge here to know if we should call addedStyleSheet() or removedStyleSheet().
- m_owner->document().styleResolverChanged();
+ if (m_owner->relAttribute().isTransitionExitingStylesheet())
+ m_owner->document().styleResolverChanged(AnalyzedStyleUpdate);
esprehn 2014/10/15 18:01:26 Why are transition sheets special? This doesn't se
Zhen Wang 2014/10/15 19:50:58 The default is FullStyleUpdate. We need AnalyzedSt
esprehn 2014/10/15 20:19:07 ditto.
Zhen Wang 2014/10/15 23:04:41 ditto
Zhen Wang 2014/12/03 17:54:29 This is fixed by resetIsTransitionDocument now.
+ else
+ m_owner->document().styleResolverChanged();
}
}
}

Powered by Google App Engine
This is Rietveld 408576698