Issue 6532091: Merge bleeding_edge revision (5922, 5934] to isolates branch....

Issue 6532091: Merge bleeding_edge revision (5922, 5934] to isolates branch.... (Closed)

Created:
9 years, 10 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/isolates/

Visibility:
Public.

Description

Merge bleeding_edge revision (5922, 5934] to isolates branch. Add temporary MERGE file that contains the latest merged revision. Committed: http://code.google.com/p/v8/source/detail?r=6900

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+221 lines, -968 lines)			Patch
M	ChangeLog	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A	MERGE	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/arm/deoptimizer-arm.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/atomicops_internals_x86_msvc.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/deoptimizer.h	View		5 chunks	+20 lines, -20 lines	0 comments	Download
M	src/deoptimizer.cc	View		15 chunks	+44 lines, -36 lines	0 comments	Download
M	src/flag-definitions.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/frames.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/hydrogen.cc	View		3 chunks	+19 lines, -9 lines	0 comments	Download
M	src/ia32/deoptimizer-ia32.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/log.h	View		6 chunks	+43 lines, -57 lines	0 comments	Download
M	src/log.cc	View	1	19 chunks	+32 lines, -140 lines	0 comments	Download
M	src/log-utils.h	View		2 chunks	+1 line, -63 lines	0 comments	Download
M	src/log-utils.cc	View		3 chunks	+1 line, -178 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform-linux.cc	View		1 chunk	+1 line, -12 lines	0 comments	Download
M	src/runtime.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime-profiler.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime-profiler.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/type-info.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/cctest.status	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	test/cctest/test-log-utils.cc	View		2 chunks	+0 lines, -170 lines	0 comments	Download
M	test/mjsunit/tools/logreader.js	View		1 chunk	+0 lines, -82 lines	0 comments	Download
M	test/mozilla/mozilla.status	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/logreader.js	View		5 chunks	+0 lines, -149 lines	0 comments	Download
M	tools/tickprocessor.js	View		4 chunks	+27 lines, -35 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

9 years, 10 months ago (2011-02-22 15:23:04 UTC) #2

LGTM with the comment addressed.


Thanks,
Vitaly

http://codereview.chromium.org/6532091/diff/1/src/log.cc
File src/log.cc (right):

http://codereview.chromium.org/6532091/diff/1/src/log.cc#newcode367
src/log.cc:367: const char* kLogEventsNames[Logger::NUMBER_OF_LOG_EVENTS] = {
Please restore "static" and yet another "const".

Expand Messages | Collapse Messages