Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 653123002: Revert of ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. (patchs… (Closed)

Created:
6 years, 2 months ago by Alexander Alekseev
Modified:
6 years, 2 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. (patchset #17 id:320001 of https://codereview.chromium.org/620563002/) Reason for revert: Speculatively reverting for https://crbug.com/422703 Original issue's description: > ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. > > BUG=419030 > > Committed: https://crrev.com/d52dffddbf0abe5ca55509a9cdedcd9b0674bb1c > Cr-Commit-Position: refs/heads/master@{#298860} TBR=dzhioev@chromium.org,nkostylev@chromium.org NOTREECHECKS=true NOTRY=true BUG=422703 Committed: https://crrev.com/f09329c436f4929c1f9ffd59e49aa4aef441338b Cr-Commit-Position: refs/heads/master@{#299480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -394 lines) Patch
M chrome/browser/chromeos/base/locale_util.h View 2 chunks +3 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/base/locale_util.cc View 6 chunks +24 lines, -27 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 4 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 3 chunks +16 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 2 chunks +17 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_terms_of_service.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/l10n_util.h View 4 chunks +3 lines, -25 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/l10n_util.cc View 8 chunks +32 lines, -158 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.h View 6 chunks +8 lines, -20 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 7 chunks +70 lines, -87 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653123002/1
6 years, 2 months ago (2014-10-14 14:32:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 14:33:11 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f09329c436f4929c1f9ffd59e49aa4aef441338b Cr-Commit-Position: refs/heads/master@{#299480}
6 years, 2 months ago (2014-10-14 14:33:58 UTC) #4
Alexander Alekseev
6 years, 2 months ago (2014-10-16 13:05:28 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/658903004/ by alemate@chromium.org.

The reason for reverting is: The speculative revert didn't help..

Powered by Google App Engine
This is Rietveld 408576698