Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: chrome/browser/chromeos/login/ui/login_display_host_impl.cc

Issue 653123002: Revert of ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. (patchs… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/ui/login_display_host_impl.cc
diff --git a/chrome/browser/chromeos/login/ui/login_display_host_impl.cc b/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
index f47cecedc5ee28921b5e8ecf5be4206fdbc3f5b8..e078e824f7b0a2da2c3876f255df1d96efd5cb05 100644
--- a/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
+++ b/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
@@ -200,10 +200,11 @@ struct ShowLoginWizardSwitchLanguageCallbackData {
void OnLanguageSwitchedCallback(
scoped_ptr<ShowLoginWizardSwitchLanguageCallbackData> self,
- const chromeos::locale_util::LanguageSwitchResult& result) {
- if (!result.success)
- LOG(WARNING) << "Locale could not be found for '" << result.requested_locale
- << "'";
+ const std::string& locale,
+ const std::string& loaded_locale,
+ const bool success) {
+ if (!success)
+ LOG(WARNING) << "Locale could not be found for '" << locale << "'";
ShowLoginWizardFinish(
self->first_screen_name, self->startup_manifest, self->display_host);
@@ -1292,12 +1293,13 @@ void ShowLoginWizard(const std::string& first_screen_name) {
new ShowLoginWizardSwitchLanguageCallbackData(
first_screen_name, startup_manifest, display_host));
- locale_util::SwitchLanguageCallback callback(
- base::Bind(&OnLanguageSwitchedCallback, base::Passed(data.Pass())));
+ scoped_ptr<locale_util::SwitchLanguageCallback> callback(
+ new locale_util::SwitchLanguageCallback(
+ base::Bind(&OnLanguageSwitchedCallback, base::Passed(data.Pass()))));
// Load locale keyboards here. Hardware layout would be automatically enabled.
locale_util::SwitchLanguage(
- locale, true, true /* login_layouts_only */, callback);
+ locale, true, true /* login_layouts_only */, callback.Pass());
}
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698